usb: cdns3: fix static checker warning.
authorFrank Li <frank.li@nxp.com>
Wed, 10 Mar 2021 16:01:25 +0000 (10:01 -0600)
committerPeter Chen <peter.chen@kernel.org>
Mon, 12 Apr 2021 12:19:21 +0000 (20:19 +0800)
commit575dd7ece61fa93270cb5749708b140a9c9cf947
treeaa384ae197c38d05500d925e8f42ccbb4d04e74e
parentef32e0513a130945a08debbbc6d126b54c59fa58
usb: cdns3: fix static checker warning.

The patch c450e48eb570: "usb: cdns3: add power lost support for
system resume" from Feb 18, 2021, leads to the following static
checker warning:

        drivers/usb/cdns3/core.c:551 cdns_resume()
        error: uninitialized symbol 'ret'.

drivers/usb/cdns3/core.c
544
545     if (!role_changed) {
546            if (cdns->role == USB_ROLE_HOST)
547                  ret = cdns_drd_host_on(cdns);
548     else if (cdns->role == USB_ROLE_DEVICE)
549            ret = cdns_drd_gadget_on(cdns);

"ret" is uninitialized at else branch.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Frank Li <frank.li@nxp.com>
Signed-off-by: Peter Chen <peter.chen@kernel.org>
drivers/usb/cdns3/core.c