tracing/probes: Handle system names with hyphens
authorSteven Rostedt (Google) <rostedt@goodmis.org>
Tue, 22 Nov 2022 17:23:45 +0000 (12:23 -0500)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Sat, 10 Dec 2022 04:48:05 +0000 (23:48 -0500)
commit575b76cb885532aae13a9d979fd476bb2b156cb9
tree0aff746e08f85f89923bd09e49ed3acbad09c8a1
parentfff1787adaeebe66f27c01d5c40d8d2e4d79d5ee
tracing/probes: Handle system names with hyphens

When creating probe names, a check is done to make sure it matches basic C
standard variable naming standards. Basically, starts with alphabetic or
underline, and then the rest of the characters have alpha-numeric or
underline in them.

But system names do not have any true naming conventions, as they are
created by the TRACE_SYSTEM macro and nothing tests to see what they are.
The "xhci-hcd" trace events has a '-' in the system name. When trying to
attach a eprobe to one of these trace points, it fails because the system
name does not follow the variable naming convention because of the
hyphen, and the eprobe checks fail on this.

Allow hyphens in the system name so that eprobes can attach to the
"xhci-hcd" trace events.

Link: https://lore.kernel.org/all/Y3eJ8GiGnEvVd8%2FN@macondo/
Link: https://lore.kernel.org/linux-trace-kernel/20221122122345.160f5077@gandalf.local.home
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: stable@vger.kernel.org
Fixes: 5b7a96220900e ("tracing/probe: Check event/group naming rule at parsing")
Reported-by: Rafael Mendonca <rafaelmendsr@gmail.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace.h
kernel/trace/trace_probe.c