fs/remap: constrain dedupe of EOF blocks
authorDave Chinner <dchinner@redhat.com>
Wed, 13 Jul 2022 07:49:15 +0000 (17:49 +1000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 13 Jul 2022 17:28:16 +0000 (10:28 -0700)
commit5750676b64a561f7ec920d7c6ba130fc9c7378f3
tree6c3fe0fff43edfd00561eaa1dd09258ef6e74df0
parentb047602d579b4fb028128a525f056bbdc890e7f0
fs/remap: constrain dedupe of EOF blocks

If dedupe of an EOF block is not constrainted to match against only
other EOF blocks with the same EOF offset into the block, it can
match against any other block that has the same matching initial
bytes in it, even if the bytes beyond EOF in the source file do
not match.

Fix this by constraining the EOF block matching to only match
against other EOF blocks that have identical EOF offsets and data.
This allows "whole file dedupe" to continue to work without allowing
eof blocks to randomly match against partial full blocks with the
same data.

Reported-by: Ansgar Lößer <ansgar.loesser@tu-darmstadt.de>
Fixes: 1383a7ed6749 ("vfs: check file ranges before cloning files")
Link: https://lore.kernel.org/linux-fsdevel/a7c93559-4ba1-df2f-7a85-55a143696405@tu-darmstadt.de/
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/remap_range.c