mount: clarify that umount retries do not (anymore) allow multiple timeouts
authorAlan Jenkins <alan.christopher.jenkins@gmail.com>
Mon, 22 Jan 2018 17:42:25 +0000 (17:42 +0000)
committerAlan Jenkins <alan.christopher.jenkins@gmail.com>
Tue, 23 Jan 2018 11:09:18 +0000 (11:09 +0000)
commit570183612189f5dcc4f7a613cd13da43d652b4cf
treeb792cf4a9008380578c685e4a12e63ad17ebce77
parent006aabbd052ce46ec35c8f90afe042f84c81c643
mount: clarify that umount retries do not (anymore) allow multiple timeouts

It _looks_ as if, back when we used to retry unsuccessful calls to umount,
this would have inflated the effective timeout.  Multiplying it by
RETRY_UMOUNT_MAX.  Which is set to 32.

I'm surprised if it's true: I would have expected it to be noticed during
the work on NFS timeouts.  But I can't see what would have stopped it.

Clarify that I do not expect this to happen anymore.  I think each
individual umount call is allowed up to the full timeout, but if umount
ever exited with a signal status, we would stop retrying.

To be extra clear, make sure that we do not retry in the event that umount
perversely returned EXIT_SUCCESS after receiving SIGTERM.
src/core/mount.c