[Android] Fix various issues in object dispose methods. (#6467)
authorKevin Petit <kevin.petit@outlook.com>
Fri, 28 Jun 2019 10:53:49 +0000 (12:53 +0200)
committerRui Marinho <me@ruimarinho.net>
Fri, 28 Jun 2019 10:53:49 +0000 (11:53 +0100)
commit56e99c84cbdacc6f06684fd15f6adfc49e93f36c
tree44cf76b6eb0e5af991a2790a19df9d16a4afd499
parentbff446926da7f83cd515e920fac5da594a47cd45
[Android] Fix various issues in object dispose methods. (#6467)

* Android - Fix various issues in object dispose methods.

* Tear down old element before disposing the ItemViewAdapter.

* More fixes.

* NavigationPageRenderer - Reorder ResetToolbar and remove view before dispose
ShellSectionRenderer - Call base.Destroy last + Remove and destroy _scrollview

* Remove obsolete code.

* Fix build.
18 files changed:
Xamarin.Forms.Platform.Android/AppCompat/CarouselPageRenderer.cs
Xamarin.Forms.Platform.Android/AppCompat/FormsAppCompatActivity.cs
Xamarin.Forms.Platform.Android/AppCompat/ImageButtonRenderer.cs
Xamarin.Forms.Platform.Android/AppCompat/MasterDetailPageRenderer.cs
Xamarin.Forms.Platform.Android/AppCompat/NavigationPageRenderer.cs
Xamarin.Forms.Platform.Android/AppCompat/Platform.cs
Xamarin.Forms.Platform.Android/AppCompat/ShellFragmentContainer.cs
Xamarin.Forms.Platform.Android/AppCompat/TabbedPageRenderer.cs
Xamarin.Forms.Platform.Android/CollectionView/ItemsViewRenderer.cs
Xamarin.Forms.Platform.Android/FastRenderers/AutomationPropertiesProvider.cs
Xamarin.Forms.Platform.Android/FastRenderers/ButtonRenderer.cs
Xamarin.Forms.Platform.Android/FastRenderers/FrameRenderer.cs
Xamarin.Forms.Platform.Android/FastRenderers/ImageRenderer.cs
Xamarin.Forms.Platform.Android/FastRenderers/LabelRenderer.cs
Xamarin.Forms.Platform.Android/FastRenderers/VisualElementRenderer.cs
Xamarin.Forms.Platform.Android/Renderers/ShellSectionRenderer.cs
Xamarin.Forms.Platform.Android/VisualElementPackager.cs
Xamarin.Forms.Platform.Android/VisualElementRenderer.cs