Revert GCStrategy ownership changes
authorPhilip Reames <listmail@philipreames.com>
Mon, 26 Jan 2015 18:26:35 +0000 (18:26 +0000)
committerPhilip Reames <listmail@philipreames.com>
Mon, 26 Jan 2015 18:26:35 +0000 (18:26 +0000)
commit56a03938f7a536dc2cef3c42ed67b3f218a1c758
treee999a35203421bc8cc440c5f607197ae265219be
parent39571b37a38d289f0895ca060eb1d6f579300af6
Revert GCStrategy ownership changes

This change reverts the interesting parts of 226311 (and 227046).  This change introduced two problems, and I've been convinced that an alternate approach is preferrable anyways.

The bugs were:
- Registery appears to require all users be within the same linkage unit.  After this change, asking for "statepoint-example" in Transform/ would sometimes get you nullptr, whereas asking the same question in CodeGen would return the right GCStrategy.  The correct long term fix is to get rid of the utter hack which is Registry, but I don't have time for that right now.  227046 appears to have been an attempt to fix this, but I don't believe it does so completely.
- GCMetadataPrinter::finishAssembly was being called more than once per GCStrategy.  Each Strategy was being added to the GCModuleInfo multiple times.

Once I get time again, I'm going to split GCModuleInfo into the gc.root specific part and a GCStrategy owning Analysis pass.  I'm probably also going to kill off the Registry.  Once that's done, I'll move the new GCStrategyAnalysis and all built in GCStrategies into Analysis.  (As original suggested by Chandler.)  This will accomplish my original goal of being able to access GCStrategy from Transform/  without adding all of the builtin GCs to IR/.

llvm-svn: 227109
19 files changed:
llvm/include/llvm/CodeGen/GCMetadata.h
llvm/include/llvm/CodeGen/GCMetadataPrinter.h
llvm/include/llvm/CodeGen/GCStrategy.h [moved from llvm/include/llvm/IR/GCStrategy.h with 97% similarity]
llvm/include/llvm/IR/Function.h
llvm/lib/CodeGen/CMakeLists.txt
llvm/lib/CodeGen/ErlangGC.cpp
llvm/lib/CodeGen/GCMetadata.cpp
llvm/lib/CodeGen/GCRootLowering.cpp
llvm/lib/CodeGen/GCStrategy.cpp [moved from llvm/lib/IR/GCStrategy.cpp with 90% similarity]
llvm/lib/CodeGen/OcamlGC.cpp
llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
llvm/lib/CodeGen/SelectionDAG/StatepointLowering.cpp
llvm/lib/CodeGen/ShadowStackGC.cpp
llvm/lib/CodeGen/StatepointExampleGC.cpp
llvm/lib/IR/CMakeLists.txt
llvm/lib/IR/Function.cpp
llvm/lib/IR/LLVMContextImpl.cpp
llvm/lib/IR/LLVMContextImpl.h