memory: pl353-smc: Fix refcount leak bug in pl353_smc_probe()
authorLiang He <windhl@126.com>
Sat, 16 Jul 2022 03:13:24 +0000 (11:13 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 10:34:57 +0000 (12:34 +0200)
commit566b143aa5112a0c2784e20603778518bb799537
tree571d5dd3a2c47f7c450fc5863da2860a1f48db1c
parent10df962300c2d7b29e69a4d7ec6380d5c730409e
memory: pl353-smc: Fix refcount leak bug in pl353_smc_probe()

[ Upstream commit 61b3c876c1cbdb1efd1f52a1f348580e6e14efb6 ]

The break of for_each_available_child_of_node() needs a
corresponding of_node_put() when the reference 'child' is not
used anymore. Here we do not need to call of_node_put() in
fail path as '!match' means no break.

While the of_platform_device_create() will created a new
reference by 'child' but it has considered the refcounting.

Fixes: fee10bd22678 ("memory: pl353: Add driver for arm pl353 static memory controller")
Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220716031324.447680-1-windhl@126.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/memory/pl353-smc.c