drm: Use drm_mode_init() for on-stack modes
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 18 Feb 2022 10:04:02 +0000 (12:04 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 12 Apr 2022 06:26:08 +0000 (09:26 +0300)
commit563c4a7599d8ac0f6826b33f312d886eda7938aa
treecca4b6db5262490352be5dc900d3f8bdd60ac8c0
parent73c3ed7495c67b8fbdc31cf58e6ca8757df31a33
drm: Use drm_mode_init() for on-stack modes

Initialize on-stack modes with drm_mode_init() to guarantee
no stack garbage in the list head, or that we aren't copying
over another mode's list head.

Based on the following cocci script, with manual fixups:
@decl@
identifier M;
expression E;
@@
- struct drm_display_mode M = E;
+ struct drm_display_mode M;

@@
identifier decl.M;
expression decl.E;
statement S, S1;
@@
struct drm_display_mode M;
... when != S
+ drm_mode_init(&M, &E);
+
S1

@@
expression decl.E;
@@
- &*E
+ E

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220218100403.7028-22-ville.syrjala@linux.intel.com
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
drivers/gpu/drm/drm_crtc_helper.c
drivers/gpu/drm/drm_edid.c
drivers/gpu/drm/drm_modes.c