fscrypt: don't load ->i_crypt_info before it's known to be valid
authorEric Biggers <ebiggers@google.com>
Mon, 27 Jul 2020 17:41:58 +0000 (10:41 -0700)
committerEric Biggers <ebiggers@google.com>
Thu, 30 Jul 2020 21:21:50 +0000 (14:21 -0700)
commit55e32c54bbd5741cad462c9ee00c453c72fa74b9
tree6976dfd203e60c9f95f2e8394ced4de2f45db72b
parent880253eacd304dad1143aeaed0a6f7bd389a783a
fscrypt: don't load ->i_crypt_info before it's known to be valid

In fscrypt_set_bio_crypt_ctx(), ->i_crypt_info isn't known to be
non-NULL until we check fscrypt_inode_uses_inline_crypto().  So, load
->i_crypt_info after the check rather than before.  This makes no
difference currently, but it prevents people from introducing bugs where
the pointer is dereferenced when it may be NULL.

Suggested-by: Dave Chinner <david@fromorbit.com>
Cc: Satya Tangirala <satyat@google.com>
Link: https://lore.kernel.org/r/20200727174158.121456-1-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
fs/crypto/inline_crypt.c