rxrpc: fix uninitialized pointer dereference in debug code
authorArnd Bergmann <arnd@arndb.de>
Mon, 8 Aug 2016 10:13:45 +0000 (12:13 +0200)
committerDavid Howells <dhowells@redhat.com>
Tue, 9 Aug 2016 09:51:38 +0000 (10:51 +0100)
commit55cae7a403f3b52de3dd6e4a614582541c9631af
tree83e7ce7e57b57abc3120132b411cb2182278fb63
parent1fe323aa1b2390a0c57fb0b06a782f128d49094c
rxrpc: fix uninitialized pointer dereference in debug code

A newly added bugfix caused an uninitialized variable to be
used for printing debug output. This is harmless as long
as the debug setting is disabled, but otherwise leads to an
immediate crash.

gcc warns about this when -Wmaybe-uninitialized is enabled:

net/rxrpc/call_object.c: In function 'rxrpc_release_call':
net/rxrpc/call_object.c:496:163: error: 'sp' may be used uninitialized in this function [-Werror=maybe-uninitialized]

The initialization was removed but one of the users remains.
This adds back the initialization.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 372ee16386bb ("rxrpc: Fix races between skb free, ACK generation and replying")
Signed-off-by: David Howells <dhowells@redhat.com>
net/rxrpc/call_object.c