iwlwifi: acpi: don't return valid pointer as an ERR_PTR
authorHaim Dreyfuss <haim.dreyfuss@intel.com>
Wed, 10 Feb 2021 12:29:22 +0000 (14:29 +0200)
committerLuca Coelho <luciano.coelho@intel.com>
Wed, 10 Feb 2021 12:39:41 +0000 (14:39 +0200)
commit55ae96b6acf0cacf2b33a1b5c206686a825da6d8
tree8270da21fe29d612e69e1c257abf4c03cf758bea
parent9cd3de8106a87f892e76d3ef2add1ec194b96ae8
iwlwifi: acpi: don't return valid pointer as an ERR_PTR

iwl_acpi_get_wifi_pkg() may return a valid pointer (meaning success),
while `tbl_rev` is invalid (equel to 1).
In this case, we will treat that as an error.
Subsequent "users" of this "error code" may either check for nonzero
(good; pointers are never zero) or negative
(bad; pointers may be "positive") fix that by splitting the if statement.
First check if IS_ERR(wifi_pkg) and then if tbl_rev != 0.

Signed-off-by: Haim Dreyfuss <haim.dreyfuss@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20210210142629.1c8c4b58c932.I147373f6fd364606b0282af8d402c722eb917225@changeid
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/fw/acpi.c