pinctrl: aspeed: fix regmap error handling
authorArnd Bergmann <arnd@arndb.de>
Fri, 9 Sep 2016 09:26:50 +0000 (11:26 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 13 Sep 2016 08:41:49 +0000 (10:41 +0200)
commit55956035266d8f5d825f30add0d7af3850cca0ad
tree6247ce5809160d1e0616bbd79784a5528ce81949
parent03e9888f955cc0950a15713a93af8946c56a37bb
pinctrl: aspeed: fix regmap error handling

The newly added aspeed driver tries to check for a negative return
value from a pinctrl function, but stores the intermediate value in
a 'bool' variable, which cannot work:

drivers/pinctrl/aspeed/pinctrl-aspeed.c: In function 'aspeed_sig_expr_set':
drivers/pinctrl/aspeed/pinctrl-aspeed.c:192:11: error: comparison of constant '0' with boolean expression is always false [-Werror=bool-compare]

This slightly reworks the logic to use an explicit comparison with zero
before assigning to the temporary variable.

Reported-by: Colin King <colin.king@canonical.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/aspeed/pinctrl-aspeed.c