iio: dac: ad5446: Fix ad5622_write() return value
authorPekka Korpinen <pekka.korpinen@iki.fi>
Wed, 29 Sep 2021 18:57:55 +0000 (21:57 +0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 17 Oct 2021 10:42:04 +0000 (11:42 +0100)
commit558df982d4ead9cac628153d0d7b60feae05ddc8
tree3aed132802de4381c8bfa5a6aa5332cb257d6711
parent8fc4f038fa832ec3543907fdcbe1334e1b0a8950
iio: dac: ad5446: Fix ad5622_write() return value

On success i2c_master_send() returns the number of bytes written. The
call from iio_write_channel_info(), however, expects the return value to
be zero on success.

This bug causes incorrect consumption of the sysfs buffer in
iio_write_channel_info(). When writing more than two characters to
out_voltage0_raw, the ad5446 write handler is called multiple times
causing unexpected behavior.

Fixes: 3ec36a2cf0d5 ("iio:ad5446: Add support for I2C based DACs")
Signed-off-by: Pekka Korpinen <pekka.korpinen@iki.fi>
Link: https://lore.kernel.org/r/20210929185755.2384-1-pekka.korpinen@iki.fi
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/dac/ad5446.c