PR17525 - breakpoint commands not executed when program run from -x script
authorPedro Alves <palves@redhat.com>
Mon, 12 Jan 2015 19:30:08 +0000 (19:30 +0000)
committerPedro Alves <palves@redhat.com>
Wed, 14 Jan 2015 12:34:12 +0000 (12:34 +0000)
commit5589af0e6661abe07e9a997f6324988b4b87c72f
tree0965e3dcece559312880a71038df982d8d9b06ef
parent6c400b59d574782afdb26eb6c021f28c31bb9f1c
PR17525 - breakpoint commands not executed when program run from -x script

Executing a gdb script that runs the inferior (from the command line
with -x), and has it hit breakpoints with breakpoint commands that
themselves run the target, is currently broken on async targets
(Linux, remote).

While we're executing a command list or a script, we force the
interpreter to be sync, which results in some functions nesting an
event loop and waiting for the target to stop, instead of returning
immediately and having the top level event loop handle the stop.

The issue with this bug is simply that bpstat_do_actions misses
checking whether the interpreter is sync.  When we get here, in the
case of executing a script (or, when the interpreter is sync), the
program has already advanced to the next breakpoint, through
maybe_wait_sync_command_done.  We need to process its breakpoints
immediately, just like with a sync target.

Tested on x86_64 Fedora 20.

gdb/
2015-01-14  Pedro Alves  <palves@redhat.com>

PR gdb/17525
* breakpoint.c: Include "interps.h".
(bpstat_do_actions_1): Also check whether the interpreter is
async.

gdb/testsuite/
2015-01-14  Pedro Alves  <palves@redhat.com>
    Joel Brobecker  <brobecker@adacore.com>

PR gdb/17525
* gdb.base/bp-cmds-execution-x-script.c: New file.
* gdb.base/bp-cmds-execution-x-script.exp: New file.
* gdb.base/bp-cmds-execution-x-script.gdb: New file.
gdb/ChangeLog
gdb/breakpoint.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.base/bp-cmds-execution-x-script.c [new file with mode: 0644]
gdb/testsuite/gdb.base/bp-cmds-execution-x-script.exp [new file with mode: 0644]
gdb/testsuite/gdb.base/bp-cmds-execution-x-script.gdb [new file with mode: 0644]