net: stmmac: dwmac-qcom-ethqos: Convert to platform remove callback returning void
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 8 May 2023 14:26:32 +0000 (16:26 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 10 May 2023 02:57:01 +0000 (19:57 -0700)
commit5580b559a80a3559a3b395a053f83e196aa801af
tree2aa837ccc5c1d75e8a9fe462171244a83158f013
parent360cd89064b6e466b046680e79fd833325225a3f
net: stmmac: dwmac-qcom-ethqos: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c