dma-buf/sw_sync: Replace all non-returning strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Tue, 23 May 2023 02:19:43 +0000 (02:19 +0000)
committerSumit Semwal <sumit.semwal@linaro.org>
Wed, 24 May 2023 11:02:25 +0000 (16:32 +0530)
commit5565a8e1a09a3ed2ac438a9e4f4c84c11037611d
treeb90a283d3c4d2c21cc491328eba1e5fe793fd28d
parent6a038f0183dd5d3e289f6c1fe6962de9b31f8fd2
dma-buf/sw_sync: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230523021943.2406847-1-azeemshaikh38@gmail.com
drivers/dma-buf/sw_sync.c