tpm: Disable RNG for all AMD fTPMs
authorMario Limonciello <mario.limonciello@amd.com>
Wed, 2 Aug 2023 12:25:33 +0000 (07:25 -0500)
committerJarkko Sakkinen <jarkko@kernel.org>
Mon, 7 Aug 2023 17:55:54 +0000 (17:55 +0000)
commit554b841d470338a3b1d6335b14ee1cd0c8f5d754
tree38a6f54b60c688a2af79a78614fd58a9ae66273c
parent0de030b308236a1392f924f527cf74614d8b6aef
tpm: Disable RNG for all AMD fTPMs

The TPM RNG functionality is not necessary for entropy when the CPU
already supports the RDRAND instruction. The TPM RNG functionality
was previously disabled on a subset of AMD fTPM series, but reports
continue to show problems on some systems causing stutter root caused
to TPM RNG functionality.

Expand disabling TPM RNG use for all AMD fTPMs whether they have versions
that claim to have fixed or not. To accomplish this, move the detection
into part of the TPM CRB registration and add a flag indicating that
the TPM should opt-out of registration to hwrng.

Cc: stable@vger.kernel.org # 6.1.y+
Fixes: b006c439d58d ("hwrng: core - start hwrng kthread also for untrusted sources")
Fixes: f1324bbc4011 ("tpm: disable hwrng for fTPM on some AMD designs")
Reported-by: daniil.stas@posteo.net
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217719
Reported-by: bitlord0xff@gmail.com
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217212
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
drivers/char/tpm/tpm-chip.c
drivers/char/tpm/tpm_crb.c
include/linux/tpm.h