drm/i915: fix screen flickering
authorThomas Gummerer <t.gummerer@gmail.com>
Thu, 14 May 2015 07:16:39 +0000 (09:16 +0200)
committerJani Nikula <jani.nikula@intel.com>
Tue, 19 May 2015 07:28:34 +0000 (10:28 +0300)
commit54da691deb123c045259ebf4f5c67381244f58f1
tree030b2b2fa563b62fdc47ea15ac330ace88ec9429
parente26081808edadfd257c6c9d81014e3b25e9a6118
drm/i915: fix screen flickering

Commit c9f038a1a592 ("drm/i915: Don't assume primary & cursor are
always on for wm calculation (v4)") fixes a null pointer dereference.
Setting the primary and cursor panes to false in
ilk_compute_wm_parameters to false does however give the following
errors in the kernel log and causes the screen to flicker.

[  101.133716] [drm:intel_set_cpu_fifo_underrun_reporting [i915]]
*ERROR* uncleared fifo underrun on pipe A
[  101.133725] [drm:intel_cpu_fifo_underrun_irq_handler [i915]]
*ERROR* CPU pipe A FIFO underrun

Always setting the panes to enabled fixes this error.

Helped-by: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Tested-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/intel_pm.c