serial: 8250_aspeed_vuart: use UPF_IOREMAP to set up register mapping
authorZev Weiss <zev@bewilderbeest.net>
Mon, 10 May 2021 01:42:31 +0000 (20:42 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 14:16:30 +0000 (16:16 +0200)
commit54da3e381c2b55289b220601f403f17df7b20597
tree73f914ea70ff81421c8e9e36e8010142843fb783
parentc9805fbf9d89c32c7ea4a6c5c3a66244aab06584
serial: 8250_aspeed_vuart: use UPF_IOREMAP to set up register mapping

Previously this driver's use of devm_ioremap_resource() led to
duplicated calls to __release_region() when unbinding it (one from
serial8250_release_std_resource() and one from devres_release_all()),
the second of which resulted in a warning message:

  # echo 1e787000.serial > /sys/bus/platform/drivers/aspeed-vuart/unbind
  [33091.774200] Trying to free nonexistent resource <000000001e787000-000000001e78703f>

With this change the driver uses the generic serial8250 code's
UPF_IOREMAP to take care of the register mapping automatically instead
of doing its own devm_ioremap_resource(), thus avoiding the duplicate
__release_region() on unbind.

In doing this we eliminate vuart->regs, since it merely duplicates
vuart->port->port.membase, which we now use for our I/O accesses.

Reported-by: Andrew Jeffery <andrew@aj.id.au>
Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Link: https://lore.kernel.org/r/20210510014231.647-4-zev@bewilderbeest.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_aspeed_vuart.c