Remove last Ada cleanups
authorTom Tromey <tom@tromey.com>
Fri, 25 May 2018 19:32:20 +0000 (13:32 -0600)
committerTom Tromey <tom@tromey.com>
Mon, 4 Jun 2018 21:33:28 +0000 (15:33 -0600)
commit54d343a24019367e85bb2e90966f2da483868637
tree9aae0197236294bfc9eac107aa2feb505145565a
parent178d6a638693d1a7a66b0553f16b1df95b4f27ee
Remove last Ada cleanups

This removes the last cleanups from the Ada code by changing
ada_lookup_symbol_list's out parameter to be a std::vector, and then
fixing up the fallout.

This is a relatively shallow change.  Deeper changes are possible, for
example (1) changing various other functions to accept a vector rather
than a pointer, or (2) changing ada_lookup_symbol_list to return the
vector and omitting the length entirely.

Tested by the buildbot, but I'll wait for Joel to test these as well.

gdb/ChangeLog
2018-06-04  Tom Tromey  <tom@tromey.com>

* ada-lang.h (ada_lookup_symbol_list): Update.
* ada-lang.c (resolve_subexp): Update.
(symbols_are_identical_enums): Change type of syms.  Remove nsyms
parameter.
(remove_extra_symbols, remove_irrelevant_renamings): Likewise.
(ada_lookup_symbol_list_worker, ada_lookup_symbol_list): Change
results parameter to std::vector.
(ada_iterate_over_symbols, ada_lookup_symbol, get_var_value):
Update.
* ada-exp.y (block_lookup): Update.
(select_possible_type_sym): Change type of syms.  Remove nsyms
parameter.
(write_var_or_type, write_name_assoc): Update.
gdb/ChangeLog
gdb/ada-exp.y
gdb/ada-lang.c
gdb/ada-lang.h