[mlir:Parser] Always splice parsed operations to the end of the parsed block
authorRiver Riddle <riddleriver@gmail.com>
Mon, 3 Oct 2022 19:26:12 +0000 (12:26 -0700)
committerRiver Riddle <riddleriver@gmail.com>
Wed, 5 Oct 2022 20:11:38 +0000 (13:11 -0700)
commit54cdc03dfadfe35a6a98a5970a5b850868176642
tree910103e781f3f49a301be5fc255cbcbec21d0bbb
parent5301826fa86aa520b65c86abbe3b3a7194849e27
[mlir:Parser] Always splice parsed operations to the end of the parsed block

The current splicing behavior dates back to when all blocks had terminators,
so we would "helpfully" splice before the terminator. This doesn't make sense
anymore, and leads to somewhat unexpected results when parsing multiple
pieces of IR into the same block.

Differential Revision: https://reviews.llvm.org/D135096
mlir/lib/AsmParser/Parser.cpp
mlir/lib/Bytecode/Reader/BytecodeReader.cpp
mlir/unittests/Parser/ParserTest.cpp