ALSA: hda: Fix UAF of leds class devs at unbinding
authorTakashi Iwai <tiwai@suse.de>
Wed, 26 Jan 2022 14:50:11 +0000 (15:50 +0100)
committerTakashi Iwai <tiwai@suse.de>
Wed, 26 Jan 2022 14:56:35 +0000 (15:56 +0100)
commit549f8ffc7b2f7561bea7f90930b6c5104318e87b
treeba1896a0991519146ffc5e2a94af608fbe022b45
parente783362eb54cd99b2cac8b3a9aeac942e6f6ac07
ALSA: hda: Fix UAF of leds class devs at unbinding

The LED class devices that are created by HD-audio codec drivers are
registered via devm_led_classdev_register() and associated with the
HD-audio codec device.  Unfortunately, it turned out that the devres
release doesn't work for this case; namely, since the codec resource
release happens before the devm call chain, it triggers a NULL
dereference or a UAF for a stale set_brightness_delay callback.

For fixing the bug, this patch changes the LED class device register
and unregister in a manual manner without devres, keeping the
instances in hda_gen_spec.

Reported-by: Alexander Sergeyev <sergeev917@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20220111195229.a77wrpjclqwrx4bx@localhost.localdomain
Link: https://lore.kernel.org/r/20220126145011.16728-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_generic.c
sound/pci/hda/hda_generic.h