bpf: Unbreak BPF_PROG_TYPE_KPROBE when kprobe is called via do_int3
authorAlexei Starovoitov <ast@kernel.org>
Wed, 3 Feb 2021 07:06:36 +0000 (23:06 -0800)
committerDaniel Borkmann <daniel@iogearbox.net>
Wed, 3 Feb 2021 14:54:22 +0000 (15:54 +0100)
commit548f1191d86ccb9bde2a5305988877b7584c01eb
treec66c02041a6024fa628f90dee231091e4594e8d5
parent3aaf0a27ffc29b19a62314edd684b9bc6346f9a8
bpf: Unbreak BPF_PROG_TYPE_KPROBE when kprobe is called via do_int3

The commit 0d00449c7a28 ("x86: Replace ist_enter() with nmi_enter()")
converted do_int3 handler to be "NMI-like".
That made old if (in_nmi()) check abort execution of bpf programs
attached to kprobe when kprobe is firing via int3
(For example when kprobe is placed in the middle of the function).
Remove the check to restore user visible behavior.

Fixes: 0d00449c7a28 ("x86: Replace ist_enter() with nmi_enter()")
Reported-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Tested-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Link: https://lore.kernel.org/bpf/20210203070636.70926-1-alexei.starovoitov@gmail.com
kernel/trace/bpf_trace.c