Revert "drivers/net/wan/hdlc_fr: Fix a double free in pvc_xmit"
authorXie He <xie.he.0141@gmail.com>
Mon, 3 May 2021 03:51:36 +0000 (20:51 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 May 2021 07:50:05 +0000 (09:50 +0200)
commit545dbb1bbeff73e1bf58be718fcb62c69c18ce34
tree71fd807c2def8286794e583913aa3c732bb7b02f
parent96e308a36efe913db4131a8a494b940360c85a5f
Revert "drivers/net/wan/hdlc_fr: Fix a double free in pvc_xmit"

commit d362fd0be456dba2d3d58a90b7a193962776562b upstream.

This reverts commit 1b479fb80160
("drivers/net/wan/hdlc_fr: Fix a double free in pvc_xmit").

1. This commit is incorrect. "__skb_pad" will NOT free the skb on
failure when its "free_on_error" parameter is "false".

2. This commit claims to fix my commit. But it didn't CC me??

Fixes: 1b479fb80160 ("drivers/net/wan/hdlc_fr: Fix a double free in pvc_xmit")
Cc: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Signed-off-by: Xie He <xie.he.0141@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wan/hdlc_fr.c