Move the persistent variable counter into Target
authorAdrian Prantl <aprantl@apple.com>
Mon, 30 Apr 2018 23:59:15 +0000 (23:59 +0000)
committerAdrian Prantl <aprantl@apple.com>
Mon, 30 Apr 2018 23:59:15 +0000 (23:59 +0000)
commit5435f78046ee39f7bec4be7833cb0a86043f8aa2
treedf2c9233d60e383508bad100b33fabb427ed43c8
parent763cd2a98a61083593cd8f167bf6d27aa7eb6d96
Move the persistent variable counter into Target
so it can be shared across multiple language plugins.

In a multi-language project it is counterintuitive to have a result
variables reuse numbers just because they are using a different
language plugin in LLDB (but not for example, when they are
Objective-C versus C++, since they are both handled by Clang).

This is NFC on llvm.org except for the Go plugin.

rdar://problem/39299889

Differential Revision: https://reviews.llvm.org/D46083

llvm-svn: 331234
lldb/include/lldb/Expression/ExpressionVariable.h
lldb/include/lldb/Target/Target.h
lldb/source/Core/ValueObject.cpp
lldb/source/Expression/Materializer.cpp
lldb/source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.cpp
lldb/source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.h
lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.h
lldb/source/Plugins/ExpressionParser/Go/GoUserExpression.cpp
lldb/source/Plugins/ExpressionParser/Go/GoUserExpression.h
lldb/source/Target/ABI.cpp