drm/komeda: Annotate dma-fence critical section in commit path
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 21 Jan 2021 15:29:52 +0000 (16:29 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 23 Feb 2021 11:54:20 +0000 (12:54 +0100)
commit53fc08c23a323884d11b178d12ce55043690eb0f
treea6e6b9df5cb889afc57cba682f551776cf8be39b
parent9e5eb5e1b60a547067c2b305461c71d1c2f2bffa
drm/komeda: Annotate dma-fence critical section in commit path

Like the helpers, nothing special. Well except not, because we the
critical section extends until after hw_done(), since that's the last
thing which could hold up a subsequent atomic commit. That means the
wait_for_flip_done is included, but that's not a problem, we're
allowed to call dma_fence_wait() from signalling critical sections.
Even on our own fence (which this does), it's just a bit confusing.
But in a way those last 2 function calls are already part of the fence
signalling critical section for the next atomic commit.

Reading this I'm wondering why komeda waits for flip_done() before
calling hw_done(), which is a bit backwards (but hey hw can be
special). Might be good to throw a comment in there that explains why,
because the original commit that added this just doesn't.

v2: Small rebase

Reviewed-by: James Qian Wang <james.qian.wang@arm.com> (v1)
Cc: "James (Qian) Wang" <james.qian.wang@arm.com>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Mihail Atanassov <mihail.atanassov@arm.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210121152959.1725404-5-daniel.vetter@ffwll.ch
drivers/gpu/drm/arm/display/komeda/komeda_kms.c