Corrected D27428: Do not use the alignment-rounded-up size with secondary 43/182743/2
authorKostya Kortchinsky <kostyak@google.com>
Fri, 22 Jun 2018 12:26:11 +0000 (15:26 +0300)
committerDongkyun Son <dongkyun.s@samsung.com>
Thu, 19 Jul 2018 09:10:21 +0000 (09:10 +0000)
commit53f3195f0638977d702afd4003b1985509c80263
treebd1f86deeee1f7523b97bafc1379e0721029c9a5
parentea6505b08f4afe73eb99445c4a26eccbfcd7db70
Corrected D27428: Do not use the alignment-rounded-up size with secondary

Summary:
I atually had an integer overflow on 32-bit with D27428 that didn't reproduce
locally, as the test servers would manage allocate addresses in the 0xffffxxxx
range, which led to some issues when rounding addresses.

At this point, I feel that Scudo could benefit from having its own combined
allocator, as we don't get any benefit from the current one, but have to work
around some hurdles (alignment checks, rounding up that is no longer needed,
extraneous code).

Reviewers: kcc, alekseyshl

Subscribers: llvm-commits, kubabrecka

Differential Revision: https://reviews.llvm.org/D27681

git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@289572 91177308-0d34-0410-b5e6-96231b3b80d8

Change-Id: If9f3b384566cffa0bdd1740ef2266a6a9d5f6fa4
libsanitizer/sanitizer_common/sanitizer_allocator_combined.h