evm: Check also if *tfm is an error pointer in init_desc()
authorRoberto Sassu <roberto.sassu@huawei.com>
Mon, 27 Apr 2020 10:28:56 +0000 (12:28 +0200)
committerMimi Zohar <zohar@linux.ibm.com>
Fri, 8 May 2020 01:30:58 +0000 (21:30 -0400)
commit53de3b080d5eae31d0de219617155dcc34e7d698
treef163f0adbe08a441fa3f511bedf14db99a8da68c
parent0014cc04e8ec077dc482f00c87dfd949cfe2b98f
evm: Check also if *tfm is an error pointer in init_desc()

This patch avoids a kernel panic due to accessing an error pointer set by
crypto_alloc_shash(). It occurs especially when there are many files that
require an unsupported algorithm, as it would increase the likelihood of
the following race condition:

Task A: *tfm = crypto_alloc_shash() <= error pointer
Task B: if (*tfm == NULL) <= *tfm is not NULL, use it
Task B: rc = crypto_shash_init(desc) <= panic
Task A: *tfm = NULL

This patch uses the IS_ERR_OR_NULL macro to determine whether or not a new
crypto context must be created.

Cc: stable@vger.kernel.org
Fixes: d46eb3699502b ("evm: crypto hash replaced by shash")
Co-developed-by: Krzysztof Struczynski <krzysztof.struczynski@huawei.com>
Signed-off-by: Krzysztof Struczynski <krzysztof.struczynski@huawei.com>
Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
security/integrity/evm/evm_crypto.c