drm/i915: Don't attempt to read an unitialized stack value
authorDamien Lespiau <damien.lespiau@intel.com>
Fri, 12 Jul 2013 15:24:40 +0000 (16:24 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 12 Jul 2013 15:33:21 +0000 (17:33 +0200)
commit53b914084950e5766b40228c4e08706e28745fa5
tree70d1d2315bc66e6a177489cc6acb674779539465
parent08e2a7de8ec86054a1272e4fc9d15fa6c18d3b16
drm/i915: Don't attempt to read an unitialized stack value

If intel_sdvo_get_value() fails here, val is unitialized and the cross
check will compare the pipe config multiplier with a bogus value.

Instead, only set encoder_pixel_multiplier when the sdvo command has
been successful. The cross check will compare the pipe config value with
0 otherwise.

v2: Do the cross check with the initial value of encoder_pixel_multiplier (0)
if the sdvo command fails (and thus keep the warning) (Daniel Vetter)

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_sdvo.c