xgl: Proposal to remove XGL_FRAMEBUFFER
authorCourtney Goeltzenleuchter <courtney@LunarG.com>
Fri, 3 Apr 2015 21:25:24 +0000 (15:25 -0600)
committerChia-I Wu <olv@lunarg.com>
Thu, 16 Apr 2015 09:33:25 +0000 (17:33 +0800)
commit53968d8ee5baaf90d2e8922c452f663c3df0c363
treea02c5aae88d85c9cf89f4d282f04463f64db2c7c
parent4953b9a7291ac1c14c9926b751085552ac8a16b4
xgl: Proposal to remove XGL_FRAMEBUFFER

bug # 13323
alpha header: r29635

Don't actually remove XGL_FRAMEBUFFER but do change how
RenderPass and Framebuffer are connected. Some comments
from the bug:

- Created a new structure XGL_RENDER_PASS_BEGIN that contains
both the XGL_RENDER_PASS and XGL_FRAMEBUFFER.

- XGL_CMD_BUFFER_GRAPHICS_BEGIN_INFO and xglCmdBeginRenderPass
both use XGL_RENDER_PASS_BEGIN to ensure they stay consistent.

- Renamed the member in XGL_CMD_BUFFER_GRAPHICS_BEGIN_INFO to
renderPassContinue with a comment to clarify that this is
only needed when a render pass is split across two command buffer.

The last has the biggest impact on this patch. The tests now
directly call CmdBeginRenderPass and CmdEndRenderPass in the
command buffer rather than set the BEGIN_INFO to a render pass and
have the driver implicitly do BeginRenderPass and EndRenderPass.
It would probably still work, but didn't seem to match the intent
with this change in the header file.
demos/cube.c
demos/tri.c
icd/nulldrv/nulldrv.c
include/xgl.h
layers/draw_state.c
layers/draw_state.cpp
layers/draw_state.h
layers/glave_snapshot.c
xgl.py