Address PR feedback
authorStephen Toub <stoub@microsoft.com>
Wed, 6 Jul 2016 03:32:12 +0000 (23:32 -0400)
committerStephen Toub <stoub@microsoft.com>
Wed, 6 Jul 2016 03:38:28 +0000 (23:38 -0400)
commit53803e9a0330045d8be9294dee225fb757b3dd6d
treefc70c035467b1494e2126461bb55555e785426a7
parent7b5e7af912853db2b97b2cf66b641ff9883cd0be
Address PR feedback

PR feedback:
- Remove AppX checks and split Environment.Windows into Environment.Windows, Environment.CoreCLR, and Environment.NETNative
- Change marshaling of service pack version field in OSVERSIONINFOEX
- Forward TickCount to EnvironmentAugments rather than implementing it via a P/Invoke
- Move environment variables support from coreclr to corefx

Plus:
- Use GetLogicalProcessorInformationEx to get the processor count, and cache it
- Use GetUserNameExW instead of GetUserNameW, as it's available on more platforms
- Fix compilation for .NET Native
- Fixed a test

Commit migrated from https://github.com/dotnet/corefx/commit/282ad11461c480a282a529c38d8fc353bc03663b
20 files changed:
src/libraries/Common/src/Interop/Unix/System.Native/Interop.GetEnviron.cs [new file with mode: 0644]
src/libraries/Common/src/Interop/Unix/System.Native/Interop.MountPoints.cs
src/libraries/Common/src/Interop/Windows/mincore/Interop.EnvironmentVariables.cs [new file with mode: 0644]
src/libraries/Common/src/Interop/Windows/mincore/Interop.ExpandEnvironmentStringsW.cs [deleted file]
src/libraries/Common/src/Interop/Windows/mincore/Interop.GetLogicalProcessorInformationEx.cs [new file with mode: 0644]
src/libraries/Common/src/Interop/Windows/mincore/Interop.GetVersionExW.cs
src/libraries/Common/src/System/Collections/Generic/LowLevelDictionary.IDictionary.cs [new file with mode: 0644]
src/libraries/Common/src/System/Collections/Generic/LowLevelDictionary.cs
src/libraries/Common/src/System/IO/DriveInfoInternal.Unix.cs
src/libraries/Native/System.Native/pal_process.cpp
src/libraries/Native/System.Native/pal_process.h
src/libraries/System.IO.FileSystem.DriveInfo/src/System/IO/DriveInfo.Unix.cs
src/libraries/System.Runtime.Extensions/src/Resources/Strings.resx
src/libraries/System.Runtime.Extensions/src/System.Runtime.Extensions.csproj
src/libraries/System.Runtime.Extensions/src/System/Environment.CoreCLR.cs [new file with mode: 0644]
src/libraries/System.Runtime.Extensions/src/System/Environment.NETNative.cs [new file with mode: 0644]
src/libraries/System.Runtime.Extensions/src/System/Environment.Unix.cs
src/libraries/System.Runtime.Extensions/src/System/Environment.Windows.cs
src/libraries/System.Runtime.Extensions/src/System/Environment.cs
src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs