x86: Fix code patching for paravirt-alternatives on 486
authorBen Hutchings <ben@decadent.org.uk>
Thu, 10 Sep 2009 01:53:50 +0000 (02:53 +0100)
committerH. Peter Anvin <hpa@zytor.com>
Thu, 10 Sep 2009 23:50:19 +0000 (16:50 -0700)
commit5367b6887e7d8c870a5da7d9b8c6e9c207684e43
treeeab362078a7964850b00f8d781aa9c9f5ff01df7
parentb19ae3999891cad21a3995c34d313dda5df014e2
x86: Fix code patching for paravirt-alternatives on 486

As reported in <http://bugs.debian.org/511703> and
<http://bugs.debian.org/515982>, kernels with paravirt-alternatives
enabled crash in text_poke_early() on at least some 486-class
processors.

The problem is that text_poke_early() itself uses inline functions
affected by paravirt-alternatives and so will modify instructions that
have already been prefetched.  Pentium and later processors will
invalidate the prefetched instructions in this case, but 486-class
processors do not.

Change sync_core() to limit prefetching on 486-class (and 386-class)
processors, and move the call to sync_core() above the call to the
modifiable local_irq_restore().

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
LKML-Reference: <1252547631.3423.134.camel@localhost>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
arch/x86/include/asm/processor.h
arch/x86/kernel/alternative.c