sparc64: fix incorrect sign extension in sys_sparc64_personality
authorDmitry V. Levin <ldv@altlinux.org>
Sat, 26 Dec 2015 23:13:27 +0000 (02:13 +0300)
committerSasha Levin <sasha.levin@oracle.com>
Wed, 3 Feb 2016 21:23:15 +0000 (16:23 -0500)
commit5301c0647782e71150361a3854ccf3e004b79bb9
tree7c8f3843e18ae6ccd43b8f2110b280dd0f165750
parent2a048a248fad2e7d49a3a5c8b9259f403182b5ac
sparc64: fix incorrect sign extension in sys_sparc64_personality

[ Upstream commit 525fd5a94e1be0776fa652df5c687697db508c91 ]

The value returned by sys_personality has type "long int".
It is saved to a variable of type "int", which is not a problem
yet because the type of task_struct->pesonality is "unsigned int".
The problem is the sign extension from "int" to "long int"
that happens on return from sys_sparc64_personality.

For example, a userspace call personality((unsigned) -EINVAL) will
result to any subsequent personality call, including absolutely
harmless read-only personality(0xffffffff) call, failing with
errno set to EINVAL.

Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
arch/sparc/kernel/sys_sparc_64.c