Replace some uses of xstrprintf with string_printf
authorSimon Marchi <simon.marchi@ericsson.com>
Tue, 7 Aug 2018 21:43:08 +0000 (17:43 -0400)
committerSimon Marchi <simon.marchi@ericsson.com>
Tue, 7 Aug 2018 21:43:08 +0000 (17:43 -0400)
commit528e15722bf67d126e17218708c0314bcfadbf6a
tree8b17bb0ea9569e150917b27be97b3ecfdc96fe62
parent96d68bd48c77fa44e517c3380ee8f224cbce00e5
Replace some uses of xstrprintf with string_printf

This patch replaces some simple uses of xstrprintf with with
string_printf, removing the need to do manual memory freeing.

The change in ada-lang.c fixes an apparent memory leak.

Regtested on the buildbot.

gdb/ChangeLog:

* common/filestuff.h (gdb_fopen_cloexec): New overload.
(gdb_open_cloexec): Likewise.
* nat/linux-osdata.c (command_from_pid): Use string_printf.
(commandline_from_pid): Likewise.
(linux_xfer_osdata_threads): Likewise.
(linux_xfer_osdata_fds): Likewise.
* ada-lang.c (is_package_name): Likewise.
* auxv.c (procfs_xfer_auxv): Likewise.
* breakpoint.c (print_one_breakpoint_location): Use
uiout::field_fmt.
(print_one_catch_solib): Use string_printf.
* coff-pe-read.c (add_pe_exported_sym): Likewise.
(add_pe_forwarded_sym): Likewise.
* dwarf2read.c (create_type_unit_group): Likewise.
(build_error_marker_type): Likewise.
* infcall.c (get_function_name): Likewise.
* valprint.c (print_converted_chars_to_obstack): Likewise.
* xtensa-tdep.c (xtensa_register_type): Likewise.
gdb/ChangeLog
gdb/ada-lang.c
gdb/auxv.c
gdb/breakpoint.c
gdb/coff-pe-read.c
gdb/common/filestuff.h
gdb/dwarf2read.c
gdb/infcall.c
gdb/nat/linux-osdata.c
gdb/valprint.c
gdb/xtensa-tdep.c