net: pch_gbe: fix pci device refcount leak while module exiting
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 17 Nov 2022 13:51:48 +0000 (21:51 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 Dec 2022 16:41:05 +0000 (17:41 +0100)
commit527046c138155722e9ea7bc49f44f7c10d529f93
tree333a6318230d47890faed195806b70ecc62ec743
parentf77c84dd5b28f4fb85bb8c0c0ff51c6870877f7f
net: pch_gbe: fix pci device refcount leak while module exiting

[ Upstream commit 5619537284f1017e9f6c7500b02b859b3830a06d ]

As comment of pci_get_domain_bus_and_slot() says, it returns
a pci device with refcount increment, when finish using it,
the caller must decrement the reference count by calling
pci_dev_put().

In pch_gbe_probe(), pci_get_domain_bus_and_slot() is called,
so in error path in probe() and remove() function, pci_dev_put()
should be called to avoid refcount leak. Compile tested only.

Fixes: 1a0bdadb4e36 ("net/pch_gbe: supports eg20t ptp clock")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221117135148.301014-1-yangyingliang@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c