apparmor: fix introspection of of task mode for unconfined tasks
authorJohn Johansen <john.johansen@canonical.com>
Sat, 6 Jun 2020 01:12:21 +0000 (18:12 -0700)
committerJohn Johansen <john.johansen@canonical.com>
Sat, 6 Jun 2020 01:12:21 +0000 (18:12 -0700)
commit5268d795d6888b202ad9f2b16a254cd00d0de77b
treec221ac7e3a4e95fdb323ddf1e20bada0a3e5daa8
parent2cf002d194977c4ec8848496a9a9804a317099dd
apparmor: fix introspection of of task mode for unconfined tasks

Fix two issues with introspecting the task mode.

1. If a task is attached to a unconfined profile that is not the
   ns->unconfined profile then. Mode the mode is always reported
   as -

      $ ps -Z
      LABEL                               PID TTY          TIME CMD
      unconfined                         1287 pts/0    00:00:01 bash
      test (-)                           1892 pts/0    00:00:00 ps

   instead of the correct value of (unconfined) as shown below

      $ ps -Z
      LABEL                               PID TTY          TIME CMD
      unconfined                         2483 pts/0    00:00:01 bash
      test (unconfined)                  3591 pts/0    00:00:00 ps

2. if a task is confined by a stack of profiles that are unconfined
   the output of label mode is again the incorrect value of (-) like
   above, instead of (unconfined). This is because the visibile
   profile count increment is skipped by the special casing of
   unconfined.

Signed-off-by: John Johansen <john.johansen@canonical.com>
security/apparmor/label.c