binder: fix memory leak in error path
authorTodd Kjos <tkjos@android.com>
Fri, 21 Jun 2019 17:54:15 +0000 (10:54 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 14 Jul 2019 06:11:21 +0000 (08:11 +0200)
commit524ad00e80b7b1138e933a3dc62e67cb25baadc6
tree826a781578ed2d53d56222012daacab0220b0b63
parent294b893a41cd031394d734524bc1eebbef0707cd
binder: fix memory leak in error path

commit 1909a671dbc3606685b1daf8b22a16f65ea7edda upstream.

syzkallar found a 32-byte memory leak in a rarely executed error
case. The transaction complete work item was not freed if put_user()
failed when writing the BR_TRANSACTION_COMPLETE to the user command
buffer. Fixed by freeing it before put_user() is called.

Reported-by: syzbot+182ce46596c3f2e1eb24@syzkaller.appspotmail.com
Signed-off-by: Todd Kjos <tkjos@google.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/android/binder.c