src: fix memory leak in ExternString
authorKarl Skomski <karl@skomski.com>
Sun, 16 Aug 2015 14:09:02 +0000 (16:09 +0200)
committerRod Vagg <rod@vagg.org>
Sun, 6 Sep 2015 11:38:27 +0000 (21:38 +1000)
commit5201cb0ff188fd68ba66fcc75489379c8dd1d274
treefe099f58dfa3fec9492ab39ff683605a4bc9b1c3
parent93ba585b66cb841313c071476cf01ea221ab0d54
src: fix memory leak in ExternString

v8 will silently return an empty handle
which doesn't delete our data if string length is
above String::kMaxLength

Fixes: https://github.com/nodejs/node/issues/1374
PR-URL: https://github.com/nodejs/node/pull/2402
Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Amended by @rvagg to change author date from
  "1970-08-16 16:09:02 +0200"
to
  "2015-08-16 16:09:02 +0200"
as per discussion @ https://github.com/nodejs/node/issues/2713
lib/buffer.js
src/node_buffer.cc
src/string_bytes.cc
test/parallel/test-stringbytes-external.js