crypto: caam/qi - fix error handling in ERN handler
authorHoria Geantă <horia.geanta@nxp.com>
Wed, 31 Jul 2019 13:08:02 +0000 (16:08 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 9 Aug 2019 05:11:44 +0000 (15:11 +1000)
commit51fab3d73054ca5b06b26e20edac0486b052c6f4
tree04ce8694cb2bf55f1042a82170e23cf89b6c6c16
parentbc67d04e75260942fb534fb91673103dcad7ca96
crypto: caam/qi - fix error handling in ERN handler

ERN handler calls the caam/qi frontend "done" callback with a status
of -EIO. This is incorrect, since the callback expects a status value
meaningful for the crypto engine - hence the cryptic messages
like the one below:
platform caam_qi: 15: unknown error source

Fix this by providing the callback with:
-the status returned by the crypto engine (fd[status]) in case
it contains an error, OR
-a QI "No error" code otherwise; this will trigger the message:
platform caam_qi: 50000000: Queue Manager Interface: No error
which is fine, since QMan driver provides details about the cause of
failure

Cc: <stable@vger.kernel.org> # v5.1+
Fixes: 67c2315def06 ("crypto: caam - add Queue Interface (QI) backend support")
Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/caam/error.c
drivers/crypto/caam/qi.c
drivers/crypto/caam/regs.h