net_sched: fix a memory leak in cls_tcindex
authorCong Wang <xiyou.wangcong@gmail.com>
Sat, 16 Feb 2019 18:58:27 +0000 (10:58 -0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 21 Feb 2019 04:11:10 +0000 (20:11 -0800)
commit51dcb69de67a5141a4f39b03402b2c5160e91040
tree75927f0a5585b3610cd09d91c211fb85a5701b7b
parent3d210534cc93dab39a9d1a8d674aa2872c268d38
net_sched: fix a memory leak in cls_tcindex

(cherry picked from commit 033b228e7f26b29ae37f8bfa1bc6b209a5365e9f)

When tcindex_destroy() destroys all the filter results in
the perfect hash table, it invokes the walker to delete
each of them. However, results with class==0 are skipped
in either tcindex_walk() or tcindex_delete(), which causes
a memory leak reported by kmemleak.

This patch fixes it by skipping the walker and directly
deleting these filter results so we don't miss any filter
result.

As a result of this change, we have to initialize exts->net
properly in tcindex_alloc_perfect_hash(). For net-next, we
need to consider whether we should initialize ->net in
tcf_exts_init() instead, before that just directly test
CONFIG_NET_CLS_ACT=y.

Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/cls_tcindex.c