mmc: tmio: fix SCC error handling to avoid false positive CRC error
authorTakeshi Saito <takeshi.saito.xv@renesas.com>
Wed, 15 May 2019 18:23:46 +0000 (20:23 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 28 May 2019 08:19:27 +0000 (10:19 +0200)
commit51b72656bb39fdcb8f3174f4007bcc83ad1d275f
tree13a341420851ea95f20c901280f8b4537e43c428
parentd96dc68e9890b121665bfe44599c98ada044a523
mmc: tmio: fix SCC error handling to avoid false positive CRC error

If an SCC error occurs during a read/write command execution, a false
positive CRC error message is output.

mmcblk0: response CRC error sending r/w cmd command, card status 0x900

check_scc_error() checks SCC_RVSREQ.RVSERR bit. RVSERR detects a
correction error in the next (up or down) delay tap position. However,
since the command is successful, only retuning needs to be executed.
This has been confirmed by HW engineers.

Thus, on SCC error, set retuning flag instead of setting an error code.

Fixes: b85fb0a1c8ae ("mmc: tmio: Fix SCC error detection")
Signed-off-by: Takeshi Saito <takeshi.saito.xv@renesas.com>
[wsa: updated comment and commit message, removed some braces]
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: stable@vger.kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/tmio_mmc_core.c