Remove signing support from (lib)rpmbuild
authorPanu Matilainen <pmatilai@redhat.com>
Fri, 20 Aug 2010 14:50:51 +0000 (17:50 +0300)
committerPanu Matilainen <pmatilai@redhat.com>
Fri, 20 Aug 2010 15:04:11 +0000 (18:04 +0300)
commit51a05e7a9fbd5d066a57fa763b78ada01e36ae30
tree6b002d55a2767f2f680014d289f67ef6f6c3b26a
parentd4d87cca0ee8d45e839099a216215414fabf35f0
Remove signing support from (lib)rpmbuild
- Signing is better done in an environment completely separated from
  the process of actually building packages. This is how its generally
  done anyway by distros, this change just forces the issue.
- While signing on build seems handy and saves some io-churn, this
  is very insecure as your precious secret passphrase remains unencrypted
  in memory for the entire duration of the build where it's accessible
  to whatever happens to be building. This change doesn't
  affect fix the issue of unencrypted passphrase residing in memory
  and potentially getting swapped out, it only limits the exposure
  to the actual signing process which isn't subject to unknown scripts
  poking around.
- Minimally preserve rpmbuild's --sign functionality via popt --pipe hack
  to call rpm --addsign when build completes
build/buildio.h
build/pack.c
build/parseSpec.c
build/poptBT.c
build/rpmbuild.h
build/rpmspec.h
build/spec.c
lib/rpmcli.h
rpmbuild.c
rpmpopt.in
tools/rpminject.c