lib/stacktrace: drop impossible WARN_ON for depot_init_pool
authorAndrey Konovalov <andreyknvl@google.com>
Fri, 10 Feb 2023 21:16:00 +0000 (22:16 +0100)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 17 Feb 2023 04:43:51 +0000 (20:43 -0800)
commit514d5c557b8b590a80f0569af5ae5f4d455ecef2
treea4813263ac0742521e54e22d1520966a75317fff
parentcb788e84a4cfe47941cded45b5ca81a917fbb1a6
lib/stacktrace: drop impossible WARN_ON for depot_init_pool

depot_init_pool has two call sites:

1. In depot_alloc_stack with a potentially NULL prealloc.
2. In __stack_depot_save with a non-NULL prealloc.

At the same time depot_init_pool can only return false when prealloc is
NULL.

As the second call site makes sure that prealloc is not NULL, the WARN_ON
there can never trigger. Thus, drop the WARN_ON and also move the prealloc
check from depot_init_pool to its first call site.

Also change the return type of depot_init_pool to void as it now always
returns true.

Link: https://lkml.kernel.org/r/ce149f9bdcbc80a92549b54da67eafb27f846b7b.1676063693.git.andreyknvl@google.com
Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Reviewed-by: Alexander Potapenko <glider@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/stackdepot.c