mac80211: fils_aead: fix encrypt error handling
authorArnd Bergmann <arnd@arndb.de>
Fri, 28 Oct 2016 10:25:53 +0000 (12:25 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Fri, 28 Oct 2016 10:59:12 +0000 (12:59 +0200)
commit514877182b537372352c14a0a50822572f66e831
tree72b8486ab387ceabb1e4661d97c27edab98804d1
parent088e8df82f91a24728d49d9532cab7ebdee5117f
mac80211: fils_aead: fix encrypt error handling

gcc -Wmaybe-uninitialized reports a bug in aes_siv_encryp:

net/mac80211/fils_aead.c: In function ‘aes_siv_encrypt.constprop’:
net/mac80211/fils_aead.c:84:26: error: ‘tfm2’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

At the time that the memory allocation fails, 'tfm2' has not been
allocated, so we should not attempt to free it later, and we can
simply return an error.

Fixes: 39404feee691 ("mac80211: FILS AEAD protection for station mode association frames")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/fils_aead.c