objtool: Preserve special st_shndx indexes in elf_update_symbol
authorSami Tolvanen <samitolvanen@google.com>
Thu, 8 Sep 2022 21:54:58 +0000 (14:54 -0700)
committerKees Cook <keescook@chromium.org>
Mon, 26 Sep 2022 17:13:15 +0000 (10:13 -0700)
commit5141d3a06b2da1731ac82091298b766a1f95d3d8
tree94633d84a24c8e49b2e38318d6735dfaf01c672b
parent5659b598b4dcb352b1a567c55fc5a658bc80076c
objtool: Preserve special st_shndx indexes in elf_update_symbol

elf_update_symbol fails to preserve the special st_shndx values
between [SHN_LORESERVE, SHN_HIRESERVE], which results in it
converting SHN_ABS entries into SHN_UNDEF, for example. Explicitly
check for the special indexes and ensure these symbols are not
marked undefined.

Fixes: ead165fa1042 ("objtool: Fix symbol creation")
Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20220908215504.3686827-17-samitolvanen@google.com
tools/objtool/elf.c