iov_iter: Mark copy_compat_iovec_from_user() noinline
authorJosh Poimboeuf <jpoimboe@kernel.org>
Wed, 12 Apr 2023 16:46:48 +0000 (10:46 -0600)
committerJens Axboe <axboe@kernel.dk>
Wed, 12 Apr 2023 16:46:48 +0000 (10:46 -0600)
commit50f9a76ef127367847cf62999c79304e48018cfa
treeb73f899bfea93cf7f8f8552f646a8dfaa59f5026
parent3b2deb0e46da9798b694cf50bd8bea1b26dcc789
iov_iter: Mark copy_compat_iovec_from_user() noinline

After commit 6376ce56feb6 ("iov_iter: import single vector iovecs as
ITER_UBUF"), GCC does an inter-procedural compiler optimization which
moves the user_access_begin() out of copy_compat_iovec_from_user() and
into its callers:

  lib/iov_iter.o: warning: objtool: .altinstr_replacement+0x0: redundant UACCESS disable
  lib/iov_iter.o: warning: objtool: iovec_from_user.part.0+0xc7: call to copy_compat_iovec_from_user.part.0() with UACCESS enabled
  lib/iov_iter.o: warning: objtool: __import_iovec+0x21d: call to copy_compat_iovec_from_user.part.0() with UACCESS enabled

Enforce the "no UACCESS enable across function boundaries" rule by
disabling cloning for copy_compat_iovec_from_user().

Fixes: 6376ce56feb6 ("iov_iter: import single vector iovecs as ITER_UBUF")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
https://lkml.kernel.org/lkml/20230327120017.6bb826d7@canb.auug.org.au
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Tested-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
lib/iov_iter.c