Fix BroadcasterManager::RemoveListener to really remove the listener
authorReid Kleckner <rnk@google.com>
Tue, 4 Feb 2020 23:56:51 +0000 (15:56 -0800)
committerReid Kleckner <rnk@google.com>
Wed, 5 Feb 2020 01:19:44 +0000 (17:19 -0800)
commit50d2d33b8ef530fbee369cbf8e7ea4479597742d
treecb65d627b60c12477c807c352c3dfc2faf7f5eda
parent7531a5039fd7ee9b48eb8a0d0770e8dfb9fa8bdf
Fix BroadcasterManager::RemoveListener to really remove the listener

This appears to be a real bug caught by -Wunused-value. std::find_if
doesn't modify the underlying collection, it just returns an iterator
pointing to the matching element.

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D74010
lldb/source/Utility/Broadcaster.cpp