media: cedrus: fix use after free bug in cedrus_remove due to race condition
authorZheng Wang <zyytlz.wz@163.com>
Mon, 13 Mar 2023 16:31:20 +0000 (16:31 +0000)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Mon, 10 Apr 2023 13:19:58 +0000 (14:19 +0100)
commit50d0a7aea4809cef87979d4669911276aa23b71f
tree616c703f4b811834770458b48972493b2d2094e9
parent3d77e23c998872caf3f2f4b4fcd05f8ae2e7b651
media: cedrus: fix use after free bug in cedrus_remove due to race condition

In cedrus_probe, dev->watchdog_work is bound with cedrus_watchdog function.
In cedrus_device_run, it will started by schedule_delayed_work. If there is
an unfinished work in cedrus_remove, there may be a race condition and
trigger UAF bug.

CPU0                  CPU1

                    |cedrus_watchdog
cedrus_remove       |
  v4l2_m2m_release  |
  kfree(m2m_dev)    |
                    |
                    | v4l2_m2m_get_curr_priv
                    |   m2m_dev //use

Fix it by canceling the worker in cedrus_remove.

Fixes: 7c38a551bda1 ("media: cedrus: Add watchdog for job completion")
Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/sunxi/cedrus/cedrus.c