[libcxx] Improve code generation for vector::clear().
authorBruce Mitchener <bruce.mitchener@gmail.com>
Thu, 23 Mar 2017 14:39:23 +0000 (14:39 +0000)
committerBruce Mitchener <bruce.mitchener@gmail.com>
Thu, 23 Mar 2017 14:39:23 +0000 (14:39 +0000)
commit50910bf842ca2d6bf16655ef3b74a8a34ca8c5f2
tree3ee815b5ba84ca2567840b9429ba853858aa1dfc
parentc53e96cb0739f2f6efa62b254c04021520fa289b
[libcxx] Improve code generation for vector::clear().

Summary:
By manipulating a local variable in the loop, when the loop can
be optimized away (due to no non-trivial destructors), this lets
it be fully optimized away and we modify the __end_ separately.

This results in a substantial improvement in the generated code.

Prior to this change, this would be generated (on x86_64):

    movq    (%rdi), %rdx
    movq    8(%rdi), %rcx
    cmpq    %rdx, %rcx
    je    LBB2_2
    leaq    -12(%rcx), %rax
    subq    %rdx, %rax
    movabsq    $-6148914691236517205, %rdx ## imm = 0xAAAAAAAAAAAAAAAB
    mulq    %rdx
    shrq    $3, %rdx
    notq    %rdx
    leaq    (%rdx,%rdx,2), %rax
    leaq    (%rcx,%rax,4), %rax
    movq    %rax, 8(%rdi)

And after:

    movq    (%rdi), %rax
    movq    %rax, 8(%rdi)

This brings this in line with what other implementations do.

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D25241

llvm-svn: 298601
libcxx/include/vector
libcxx/test/std/containers/sequences/vector/vector.modifiers/clear.pass.cpp [new file with mode: 0644]