tools/power/x86/intel-speed-select: Remove wrong check in set_isst_id()
authorZhang Rui <rui.zhang@intel.com>
Thu, 12 Jan 2023 06:43:33 +0000 (14:43 +0800)
committerHans de Goede <hdegoede@redhat.com>
Fri, 3 Feb 2023 08:55:26 +0000 (09:55 +0100)
commit507fa17a6c46c111f6b0d2bc483c1b3563fd16c5
treebd2719cebf081b89e686ad2623a38d1cfc4316da
parent8071b210aeb96ff047fcf55fe4fa1f7e07012e90
tools/power/x86/intel-speed-select: Remove wrong check in set_isst_id()

struct isst_id *id is a pointer, comparing it with less than zero is wrong.

The check is there to make sure the id->pkg and id->die is set to -1, when
it is illegal or unavailable. Here comparing with MAX_PACKAGE_COUNT and
MAX_DIE_PER_PACKAGE is sufficient.

Hence remove the wrong check.

Signed-off-by: Zhang Rui <rui.zhang@intel.com>
[srinivas.pandruvada@linux.intel.com: Subject and changelog edits]
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
tools/power/x86/intel-speed-select/isst-config.c